Skip to content

GH-47022: [Python] Support unsigned dictionary indices in pandas conversion #48451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamreeve merged 3 commits into from
Dec 23, 2025
Merged

GH-47022: [Python] Support unsigned dictionary indices in pandas conversion #48451

adamreeve merged 3 commits into from
Dec 23, 2025

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Dec 11, 2025 •
edited
Loading

Rationale for this change

This is the ticket mentioned in #7659 which implements unsigned dictionary indices in pandas conversion.

What changes are included in this PR?

Implements unsigned dictionary indices by upcasting to signed ints in pandas conversion

Are these changes tested?

Yes via:

pytest -xvs python/pyarrow/tests/test_pandas.py::test_dictionary_with_pandas

Are there any user-facing changes?

Yes, pd.Categorical.from_codes(indices, categories=dictionary) with unsigned integers should work now as demonstrated in the tests.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

⚠️ GitHub issue #48450 has been automatically assigned in GitHub to PR creator.

@HyukjinKwon HyukjinKwon marked this pull request as draft December 11, 2025 05:20
@HyukjinKwon HyukjinKwon changed the title GH-48450: [Python][C++] Support unsigned dictionary indices in pandas conversion GH-47022: [Python][C++] Support unsigned dictionary indices in pandas conversion Dec 11, 2025
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

⚠️ GitHub issue #47022 has been automatically assigned in GitHub to PR creator.

@HyukjinKwon HyukjinKwon changed the title GH-47022: [Python][C++] Support unsigned dictionary indices in pandas conversion GH-47022: [Python] Support unsigned dictionary indices in pandas conversion Dec 11, 2025
@HyukjinKwon HyukjinKwon marked this pull request as ready for review December 11, 2025 05:37
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

⚠️ GitHub issue #47022 has been automatically assigned in GitHub to PR creator.

3 similar comments
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

⚠️ GitHub issue #47022 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

⚠️ GitHub issue #47022 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

⚠️ GitHub issue #47022 has been automatically assigned in GitHub to PR creator.

@HyukjinKwon HyukjinKwon force-pushed the GH-48450 branch 3 times, most recently from 27a89f3 to 40f6ef1 Compare December 11, 2025 22:43
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Dec 11, 2025

Should be ready for a look.

adamreeve
adamreeve reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HyukjinKwon, this looks good to me but I have one comment about the error message.

@github-actions github-actions bot added awaiting review Awaiting review awaiting committer review Awaiting committer review and removed awaiting review Awaiting review awaiting committer review Awaiting committer review labels Dec 16, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 19, 2025
adamreeve
adamreeve reviewed Dec 22, 2025
View reviewed changes
@adamreeve adamreeve merged commit de6eb89 into apache:main Dec 23, 2025
14 checks passed
@adamreeve adamreeve removed the awaiting committer review Awaiting committer review label Dec 23, 2025
@adamreeve adamreeve mentioned this pull request Dec 23, 2025
Closed
@adamreeve
Copy link
Contributor

adamreeve commented Dec 23, 2025

Thanks for adding this!

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Dec 23, 2025

Thank you @adamreeve !!!!!!!!!!!!!!!!

@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Dec 26, 2025

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit de6eb89.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them.

@HyukjinKwon HyukjinKwon deleted the GH-48450 branch December 26, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamreeve adamreeve adamreeve approved these changes

@AlenkaF AlenkaF Awaiting requested review from AlenkaF AlenkaF is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@rok rok Awaiting requested review from rok rok is a code owner

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HyukjinKwon @adamreeve